Skip to content

copy bytes optimize#633

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
hzxuzhonghu:copy-bytes
Jul 28, 2024
Merged

copy bytes optimize#633
kmesh-bot merged 3 commits intokmesh-net:mainfrom
hzxuzhonghu:copy-bytes

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Jul 25, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
copy bytes optimize
f7aad59 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Add test case
d4bd11d 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
fix lint
e300532 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.38%. Comparing base (f5f92ac) to head (e300532).
Report is 44 commits behind head on main.

Files Coverage Δ
pkg/nets/nets.go 14.28% <100.00%> (+6.59%) ⬆️
pkg/controller/workload/workload_processor.go 44.08% <57.14%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c2e03...e300532. Read the comment docs.

@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Jul 26, 2024

/assign @nlgwcy

@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Jul 28, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Jul 28, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 8071453 into kmesh-net:main Jul 28, 2024
@hzxuzhonghu hzxuzhonghu deleted the copy-bytes branch July 29, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@YaoZengzeng YaoZengzeng Awaiting requested review from YaoZengzeng

Assignees

@nlgwcy nlgwcy

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzxuzhonghu @nlgwcy @kmesh-bot