update metric_key with direction & dst_port#627
update metric_key with direction & dst_port#627kmesh-bot merged 1 commit intokmesh-net:mainfrom nlgwcy:ipv6-1
Conversation
Signed-off-by: wuchangye <wuchangye@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| bpf_memcpy(key->src_ip.ip6, sk->dst_ip6, IPV6_ADDR_LEN); | ||
| bpf_memcpy(key->dst_ip.ip6, sk->src_ip6, IPV6_ADDR_LEN); | ||
| } | ||
| key->dst_port = sk->src_port; |
There was a problem hiding this comment.
shouldn't this be dst_port>
There was a problem hiding this comment.
When DIRECTION is INBOUND, the src and dst of the sk are the opposite of the src and dst of the traffic.
So when direction is inbound, dst_port is src_port
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: