Skip to content

Bypass only for sidecar#607

Merged
kmesh-bot merged 4 commits intokmesh-net:mainfrom
hzxuzhonghu:bypass
Jul 22, 2024
Merged

Bypass only for sidecar#607
kmesh-bot merged 4 commits intokmesh-net:mainfrom
hzxuzhonghu:bypass

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Jul 18, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.71698% with 24 lines in your changes missing coverage. Please review.

Project coverage is 49.89%. Comparing base (80110be) to head (4697244).
Report is 15 commits behind head on main.

Files Coverage Δ
pkg/controller/controller.go 0.00% <0.00%> (ø)
pkg/controller/manage/manage_controller.go 63.15% <45.45%> (ø)
pkg/controller/bypass/bypass_controller.go 41.75% <61.53%> (+3.96%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f10ea...4697244. Read the comment docs.

@hzxuzhonghu
Copy link
Copy Markdown
Member Author

hzxuzhonghu commented Jul 19, 2024

Also fix #602

@hzxuzhonghu
Bypass only for sidecar
9ed3531 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
More update
8092766 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
update
5a980ac 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
update
4697244 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Jul 22, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Jul 22, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 5dbd201 into kmesh-net:main Jul 22, 2024
@hzxuzhonghu hzxuzhonghu deleted the bypass branch July 22, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@nlgwcy nlgwcy

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzxuzhonghu @nlgwcy @kmesh-bot