Skip to content

remove resync period#601

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:rm-resync
Jul 19, 2024
Merged

remove resync period#601
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:rm-resync

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu commented Jul 18, 2024 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #597

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@hzxuzhonghu
remove resync period
71e3fa0 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (eb828ce) to head (df1c32c).
Report is 32 commits behind head on main.

Files Coverage Δ
pkg/controller/bypass/bypass_controller.go 37.79% <100.00%> (ø)
pkg/controller/manage/kmesh_manage.go 58.66% <100.00%> (-2.00%) ⬇️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0534f...df1c32c. Read the comment docs.

LiZhenCheng9527
LiZhenCheng9527 reviewed Jul 18, 2024
View reviewed changes
pkg/controller/bypass/bypass_controller.go Outdated
LabelSelectorBypass = "kmesh.net/bypass=enabled"
KmeshAnnotation = "kmesh.net/redirection"
SidecarAnnotation = "sidecar.istio.io/inject"
KmeshAnnotation = "kmesh.net/redirection"
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 Jul 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a KmeshRedirectionAnnotation in constant.go

kmesh/pkg/constants/constants.go

Line 28 in 4a0534f

KmeshRedirectionAnnotation = "kmesh.net/redirection"

@hzxuzhonghu
Update
df1c32c 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@nlgwcy
Copy link
Copy Markdown
Contributor

nlgwcy commented Jul 19, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Jul 19, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit d0f10ea into kmesh-net:main Jul 19, 2024
@hzxuzhonghu hzxuzhonghu deleted the rm-resync branch July 19, 2024 06:35
@hzxuzhonghu hzxuzhonghu restored the rm-resync branch July 19, 2024 07:41
@hzxuzhonghu hzxuzhonghu deleted the rm-resync branch July 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiZhenCheng9527 LiZhenCheng9527 LiZhenCheng9527 left review comments

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@nlgwcy nlgwcy

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove default resync period

4 participants

@hzxuzhonghu @nlgwcy @kmesh-bot @LiZhenCheng9527