Skip to content

E2E test cases for service and pod ip access#596

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:more-e2e-cases
Jul 22, 2024
Merged

E2E test cases for service and pod ip access#596
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:more-e2e-cases

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Add E2E test cases of service and pod access, test whether the access is possible and whether it has been properly processed by L7, etc

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 17, 2024
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.03%. Comparing base (58cab06) to head (5a933be).
Report is 29 commits behind head on main.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ee9fd...5a933be. Read the comment docs.

@YaoZengzeng
Copy link
Copy Markdown
Member Author

@hzxuzhonghu PTAL

@hzxuzhonghu
Copy link
Copy Markdown
Member

cool

hzxuzhonghu
hzxuzhonghu previously approved these changes Jul 19, 2024

func supportsL7(opt echo.CallOptions, src, dst echo.Instance) bool {
s := src.Config().HasSidecar()
d := dst.Config().HasSidecar() || dst.Config().HasAnyWaypointProxy()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove sidecar, it is not in kmesh e2e

Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@YaoZengzeng
Copy link
Copy Markdown
Member Author

@hzxuzhonghu PTAL

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit e78e507 into kmesh-net:main Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants