Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| } | ||
|
|
||
| report_access_log(sk, tcp_sock, storage); | ||
| // report_access_log(sk, tcp_sock, storage); |
There was a problem hiding this comment.
Why remove access log report
There was a problem hiding this comment.
Because there is no processing code for accesslog data yet.
If I keep it, it will fill up the ringbuf, so I will delete it for now.
I will submit it together with the processing code for accesslog later.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.4 |
|
@nlgwcy: new pull request created: #595 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix metric key not exists error
Which issue(s) this PR fixes:
Fixes #581
Special notes for your reviewer:
Does this PR introduce a user-facing change?: