Skip to content

optimize workload update#590

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
nlgwcy:bugfix
Jul 17, 2024
Merged

optimize workload update#590
kmesh-bot merged 1 commit intokmesh-net:mainfrom
nlgwcy:bugfix

Conversation

@nlgwcy
Copy link
Copy Markdown
Contributor

@nlgwcy nlgwcy commented Jul 16, 2024

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
Even if a workload is associated with a service, the workload can still be directly accessed.
Which issue(s) this PR fixes:
Fixes #503

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: wuchangye <wuchangye@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 16, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (218841f) to head (58cab06).
Report is 10 commits behind head on main.

Files Coverage Δ
pkg/controller/workload/workload_processor.go 41.00% <100.00%> (-1.68%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b62cc3...58cab06. Read the comment docs.

@hzxuzhonghu
Copy link
Copy Markdown
Member

/cherry-pick release-0.4

@kmesh-bot
Copy link
Copy Markdown
Collaborator

@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

backend_uid := p.hashName.StrToNum(workload.GetUid())
// a Pod may be added to a certain service in the future, so it is necessary to delete the Pod info
// that was previously added as an independent Pod to the frontend map.
if err = p.deletePodFrontendData(backend_uid); err != nil {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we track the case pod ip changed in a issue

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we track the case pod ip changed in a issue

yes, it will be supported later.

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 49ee9fd into kmesh-net:main Jul 17, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

@hzxuzhonghu: new pull request created: #592

Details

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve HandleWorkload prevent losing control during workload update

3 participants