add configuration to collect kmesh metrics using Prometheus#589
add configuration to collect kmesh metrics using Prometheus#589kmesh-bot merged 2 commits intokmesh-net:mainfrom
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| metadata: | ||
| labels: | ||
| app.kubernetes.io/component: server | ||
| app.kubernetes.io/name: prometheus |
There was a problem hiding this comment.
I am not sure other labels functionality except this one
| labels: | ||
| app: kmesh | ||
| annotations: | ||
| prometheus.io/path: "status/metric" |
There was a problem hiding this comment.
should also be put into the helm directory
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
add configuration to collect kmesh metrics using Prometheus
Which issue(s) this PR fixes:
a part of #566
Special notes for your reviewer:
Does this PR introduce a user-facing change?: