Skip to content

fix make clean#587

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
Okabe-Rintarou-0:fix/makeclean
Jul 16, 2024
Merged

fix make clean#587
kmesh-bot merged 1 commit intokmesh-net:mainfrom
Okabe-Rintarou-0:fix/makeclean

Conversation

@Okabe-Rintarou-0
Copy link
Copy Markdown
Member

@Okabe-Rintarou-0 Okabe-Rintarou-0 commented Jul 16, 2024

What type of PR is this?
bug

What this PR does / why we need it:
fix make clean problem
Which issue(s) this PR fixes:
Fixes #586

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Okabe-Rintarou-0
fix make clean
218841f 
Signed-off-by: Okabe-Rintarou-0 <923048992@qq.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.78%. Comparing base (ec3e55e) to head (218841f).
Report is 10 commits behind head on main.

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e9c9d...218841f. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Jul 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Jul 16, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 7b62cc3 into kmesh-net:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make clean not clean depends/include/bpf_helper_defs_ext.h

3 participants

@Okabe-Rintarou-0 @kmesh-bot @hzxuzhonghu