Skip to content

remove arch info in build process#585

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
Okabe-Rintarou-0:enhance/arch
Jul 17, 2024
Merged

remove arch info in build process#585
kmesh-bot merged 1 commit intokmesh-net:mainfrom
Okabe-Rintarou-0:enhance/arch

Conversation

@Okabe-Rintarou-0
Copy link
Copy Markdown
Member

@Okabe-Rintarou-0 Okabe-Rintarou-0 commented Jul 16, 2024

What type of PR is this?
cleanup

What this PR does / why we need it:
remove arch info in build process
Which issue(s) this PR fixes:
Fixes #583

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Okabe-Rintarou-0
remove arch info in build process
d88f4da 
Signed-off-by: 923048992@qq.com <923048992@qq.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (548ebc1) to head (d88f4da).
Report is 431 commits behind head on main.

see 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c136...d88f4da. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The CI should cover it

@kmesh-bot kmesh-bot added the lgtm label Jul 17, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit f9687ff into kmesh-net:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove arch prefix in /hack/utils.sh

3 participants

@Okabe-Rintarou-0 @kmesh-bot @hzxuzhonghu