Skip to content

add some waypoint related E2E test cases#580

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:waypoint-testcase
Jul 17, 2024
Merged

add some waypoint related E2E test cases#580
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:waypoint-testcase

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

migrate some waypoint related E2E test cases

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Jul 16, 2024
@kmesh-bot kmesh-bot requested review from hzxuzhonghu and nlgwcy July 16, 2024 01:16
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (5094c24) to head (a0cff6e).
Report is 16 commits behind head on main.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558040c...a0cff6e. Read the comment docs.

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most codes are from istio, we need to add some document, suggest add a readme in e2e directory

opt.Count = 10
c := singleHost
if shouldBalance {
c = multipleHost
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have workload level waypoint?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, relevant test cases will be added later

- headers:
request:
add:
istio-custom-header: user-defined-value
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should update to kmesh

check.RequestHeader("Istio-Custom-Header", "user-defined-value"))
src.CallOrFail(t, opt)
})
t.NewSubTest("subset").Run(func(t framework.TestContext) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace subset with a more meaningful name

Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@YaoZengzeng
Copy link
Copy Markdown
Member Author

@hzxuzhonghu updated

Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 781fc97 into kmesh-net:main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants