Merged
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
|
/kind feature |
Merged
Member
|
please rebase |
00cd889 to
a0362c7
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
hzxuzhonghu
reviewed
Jul 9, 2024
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Contributor
Author
|
This PR is ready to merge |
nlgwcy
reviewed
Jul 9, 2024
hzxuzhonghu
reviewed
Jul 10, 2024
hzxuzhonghu
reviewed
Jul 10, 2024
pkg/controller/telemetry/metric.go
Outdated
| }() | ||
|
|
||
| // Register metrics to Prometheus and start Prometheus server | ||
| go RunPrometheusClient() |
Member
There was a problem hiding this comment.
should pass the ctx in, and make it stoppable
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
hzxuzhonghu
reviewed
Jul 10, 2024
pkg/controller/telemetry/metric.go
Outdated
| type requestMetric struct { | ||
| src [4]uint32 | ||
| dst [4]uint32 | ||
| // flow direction |
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Member
|
/cherry-pick release-0.4 |
Member
|
/lgtm |
Member
|
seems the bot is not working |
Contributor
|
/lgtm |
Member
|
/cherry-pick release-0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Implementation of metric in kmesh observability
Which issue(s) this PR fixes:
Fixes #320
Special notes for your reviewer:
Does this PR introduce a user-facing change?: