Remove unnecessary images in e2e test#1526
Conversation
Summary of ChangesHello @LiZhenCheng9527, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the end-to-end testing environment by implementing automated cleanup of the Kmesh build Docker image to conserve disk space. It also introduces a new command-line option to enable detailed debugging logs during e2e test runs, providing more control over test execution and troubleshooting. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Images now are gone, Disk space reclaimed, tests run, Debug logs now wait. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces two new flags, --build-image-clean and --debug, to the end-to-end test script. The --build-image-clean flag is used to remove the kmesh build image after the build to save disk space, and it's now enabled by default for the make e2e target. The --debug flag enables debug logging. My review found a critical syntax error in the argument parsing logic for the new --debug flag which will prevent the script from running correctly. I've provided a fix for this issue.
test/e2e/run_test.sh
Outdated
| --debug | ||
| DEBUG=true | ||
| shift | ||
| ;; |
There was a problem hiding this comment.
There is a syntax error in the case statement. The pattern for the --debug flag is missing a closing parenthesis ). This will cause a syntax error and prevent the script from executing.
| --debug | |
| DEBUG=true | |
| shift | |
| ;; | |
| --debug) | |
| DEBUG=true | |
| shift | |
| ;; |
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
150922f to
c8d1b43
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
c8d1b43 to
3097c3e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
During end-to-end testing, to free up more disk space, delete the kmesh build image after building kmesh.
Two identifiers were added in the run-e2e.sh script.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: