Skip to content

adapt to istio 1.26#1513

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:istio-126
Oct 14, 2025
Merged

adapt to istio 1.26#1513
kmesh-bot merged 2 commits intokmesh-net:mainfrom
YaoZengzeng:istio-126

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented Oct 10, 2025

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1511

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@YaoZengzeng
adapt to istio 1.26
4585ee5 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist bot commented Oct 10, 2025

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Oct 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.29%. Comparing base (07cfe78) to head (5951594).
⚠️ Report is 6 commits behind head on main.
see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c7b4f...5951594. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu reviewed Oct 11, 2025
View reviewed changes
.github/workflows/e2e-istio-1.26.yml Outdated
shell: bash
run: |
sudo ISTIO_VERSION="1.23.0" make e2e No newline at end of file
sudo ISTIO_VERSION="1.26.0" make e2e No newline at end of file
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the latest patches of 1.26

Copy link
Copy Markdown
Member Author

@YaoZengzeng YaoZengzeng Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Oct 13, 2025

what is the failure cause

@kmesh-bot kmesh-bot added size/S and removed size/XS labels Oct 14, 2025
@YaoZengzeng
fix comments
5951594 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@YaoZengzeng
Copy link
Copy Markdown
Member Author

YaoZengzeng commented Oct 14, 2025

what is the failure cause

fixed, after upgrading the OS to ubuntu 24.04

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Oct 14, 2025

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Oct 14, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 927b2e5 into kmesh-net:main Oct 14, 2025
12 checks passed
@LiZhenCheng9527 LiZhenCheng9527 mentioned this pull request Oct 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@LiZhenCheng9527 LiZhenCheng9527 Awaiting requested review from LiZhenCheng9527

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved kind/enhancement New feature or request lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support istio 1.26

4 participants

@YaoZengzeng @hzxuzhonghu @LiZhenCheng9527 @kmesh-bot