Conversation
…nts of Kmesh. Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Summary of ChangesHello @LiZhenCheng9527, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration oversight in the Kmesh deployment YAML. With Kmesh now supporting DNS proxy capabilities, this change ensures that the deployment manifest correctly enables this feature by adding the required environment variable. The update is essential for the proper functioning of the DNS proxy within the Kmesh environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. YAML lines now grow, DNS proxy takes its place, New features now live. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the KMESH_ENABLE_DNS_PROXY environment variable to the Kmesh daemonset deployment YAML, with the goal of enabling the DNS proxy feature. However, based on the provided code, this environment variable is not being read or utilized by the kmesh-daemon. This means the change, as it stands, is ineffective. I have added a critical review comment detailing this issue.
| - name: KMESH_ENABLE_DNS_PROXY | ||
| value: "true" |
There was a problem hiding this comment.
The environment variable KMESH_ENABLE_DNS_PROXY is added here, but it does not appear to be used anywhere in the provided Go source files, such as daemon/options/options.go or pkg/controller/ads/dns.go. Without code to read this variable and conditionally enable the DNS proxy feature, this change will have no effect.
To fix this, the kmesh-daemon application needs to be modified to check for this environment variable and enable the DNS proxy functionality accordingly. For example, you might use os.Getenv("KMESH_ENABLE_DNS_PROXY") and parse the boolean value to control whether the DNS controller is started.
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| fieldRef: | ||
| fieldPath: spec.nodeName | ||
| - name: KMESH_ENABLE_DNS_PROXY | ||
| value: "true" |
There was a problem hiding this comment.
It is intended to be false at beginning
There was a problem hiding this comment.
Then should we also change feature.dnsProxy.enable to false in the Helm values?
There was a problem hiding this comment.
Ah, i am mistaken. It is now enabled by default in the helm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
After Kmesh support dns proxy, the YAML file for Kmesh deployment lacks the corresponding environment variable configurations.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: