Proposal: Dns support for Dual-Engine#1436
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Flying-Tom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a comprehensive proposal and initial design for enabling DNS resolution capabilities within Kmesh's Dual-Engine mode. The primary goal is to support ServiceEntry configurations that rely on DNS resolution, ensuring seamless migration for users from Istio by leveraging and extending the recently refactored DNS module.
Highlights
- New Design Proposal: A new markdown document (
docs/proposal/dual_engine_dns.md) has been added, detailing the motivation, goals, and design specifics for integrating DNS resolution into the Dual-Engine architecture. - Dual-Engine DNS Support: The PR outlines how to extend the existing
DNSResolverto support DNS resolution for workloads originating fromServiceEntryin the Dual-Engine mode, addressing a critical feature gap. - Asynchronous DNS Handling: The proposal describes the implementation of a
WorkloadDnsControllerthat will asynchronously handle DNS resolution requests, decoupling the resolution process from the main workload processing flow. - Processor Integration: The
Processorcomponent will be updated to identifyServiceEntryworkloads lacking address information and route them to the new DNS resolution mechanism, including a retry logic for unresolved entries. - Code Style Enforcement: A minor update to
.markdownlint.ymlintroduces a rule to enforce consistent tab usage in markdown code blocks.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a KEP for adding DNS resolution support in Dual-Engine mode and adjusts markdown linting rules.
- Add a detailed proposal document outlining Dual-Engine DNS support
- Update
.markdownlint.ymlto enforce no-hard-tabs in code blocks
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/proposal/dual_engine_dns.md | New KEP draft for Dual-Engine DNS resolution support |
| .markdownlint.yml | Added no-hard-tabs rule configuration |
Comments suppressed due to low confidence (3)
docs/proposal/dual_engine_dns.md:20
- [nitpick] The
Summarysection is empty; please provide a concise overview of what this proposal achieves.
### Summary
docs/proposal/dual_engine_dns.md:52
- In the YAML example, the second
number: httpshould likely bename: httpto correctly label the port.
number: http
docs/proposal/dual_engine_dns.md:180
- A
for rangeloop cannot iterate over an integer; considerfor i := 0; i < maxRetries; i++ {.
for range maxRetries {
c9a2070 to
fcf5ce2
Compare
There was a problem hiding this comment.
Code Review
The pull request introduces DNS resolution support for the dual-engine mode, enabling seamless migration for users relying on External Name services and DNS resolution typed ServiceEntries. The changes involve refactoring the DNS module, implementing a WorkloadDnsController, and updating the Processor to handle workloads without address information.
Codecov Report✅ All modified and coverable lines are covered by tests. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Are we capturing application DNS resolution requests in this proposal? |
This proposal does not currently involve the interrcception of DNS resolution request. This proposal is to enable Kmesh to incorporate serviceEntry that If you have a need to intercept DNS resolution, can you make a separate issue to explain the exact context? |
fcf5ce2 to
80495ac
Compare
80495ac to
3aeaccb
Compare
e559eb6 to
eaa8dc6
Compare
eaa8dc6 to
a8e3a97
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
400f33e to
6d1e386
Compare
6d1e386 to
8613464
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
/lgtm |
Signed-off-by: Tom <yusencao@outlook.com>
Signed-off-by: Tom <yusencao@outlook.com>
Signed-off-by: Tom <yusencao@outlook.com>
8613464 to
bb6fe77
Compare
|
@LiZhenCheng9527 review request |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implement DNS resolution logic mentioned in #1407
Which issue(s) this PR fixes:
#1407
Special notes for your reviewer:
Does this PR introduce a user-facing change?: