Fix: bump of containernetworking/plugins#1418
Conversation
Signed-off-by: Tom <yusencao@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the containernetworking modules and adjusts test flags to disable Go inlining for compatibility with gomonkey.
- Bumps
containernetworking/cnito v1.3.0 andcontainernetworking/pluginsto v1.7.1 - Adds
-gcflags=all=-lto the Go Test workflow to disable inlining during tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Updated direct and indirect Go module versions, including CNI. |
| .github/workflows/main.yml | Added -gcflags=all=-l to the Go Test command to disable inlining. |
Comments suppressed due to low confidence (1)
.github/workflows/main.yml:62
- [nitpick] The
-gcflags=all=-lflag is added only to the main Go Test job. If your eBPF tests also usegomonkey, consider applying the same-gcflags=all=-lthere to prevent inlining issues during those tests.
sudo env LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/lib:$GITHUB_WORKSPACE/api/v2-c:$GITHUB_WORKSPACE/bpf/deserialization_to_bpf_map PKG_CONFIG_PATH=$GITHUB_WORKSPACE/mk go test -gcflags=all=-l -race -v -vet=off -coverprofile=coverage.out ./pkg/...
| github.com/containernetworking/cni v1.2.3 | ||
| github.com/containernetworking/plugins v1.6.1 | ||
| github.com/containernetworking/cni v1.3.0 | ||
| github.com/containernetworking/plugins v1.7.1 |
There was a problem hiding this comment.
[nitpick] This PR includes bumps for both direct and many indirect dependencies in one change. To reduce risk and ease review, consider isolating just the containernetworking/plugins upgrade in its own PR.
| github.com/containernetworking/plugins v1.7.1 | |
| github.com/containernetworking/plugins v1.6.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Tom <yusencao@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Bump of
containernetworking/pluginscause thegomonkeynot working in UT, use-gcflags=all=-lto disable inlining.Which issue(s) this PR fixes:
Fixes #1396
Special notes for your reviewer:
Does this PR introduce a user-facing change?: