Skip to content

Changed the metric name of grafana to match the metric name reported by kmesh#1404

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
LiZhenCheng9527:grafana-fix
May 16, 2025
Merged

Changed the metric name of grafana to match the metric name reported by kmesh#1404
kmesh-bot merged 1 commit intokmesh-net:mainfrom
LiZhenCheng9527:grafana-fix

Conversation

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 commented May 16, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Because after the #1007 changes, didn't change metrics name in grafana.
Now fix it.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@LiZhenCheng9527
Changed the metric name of grafana to match the metric name reported …
8e554d1 
…by kmesh

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kmesh-bot kmesh-bot requested a review from nlgwcy May 16, 2025 08:29
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label May 16, 2025
@kmesh-bot kmesh-bot requested a review from supercharge-xsy May 16, 2025 08:29
@YaoZengzeng
Copy link
Copy Markdown
Member

YaoZengzeng commented May 16, 2025

/lgtm

@kmesh-bot kmesh-bot added the lgtm label May 16, 2025
@YaoZengzeng
Copy link
Copy Markdown
Member

YaoZengzeng commented May 16, 2025

/approve

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (579f10b) to head (8e554d1).
Report is 5 commits behind head on main.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eed5c73...8e554d1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC This feature is not enabled by default
/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, YaoZengzeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 4f0ae8f into kmesh-net:main May 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@YaoZengzeng YaoZengzeng

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/bug Something isn't working lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiZhenCheng9527 @YaoZengzeng @kmesh-bot @hzxuzhonghu