Skip to content

prevent deletion of addresses that are already occupied by other objects#1358

Merged
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:se
May 6, 2025
Merged

prevent deletion of addresses that are already occupied by other objects#1358
kmesh-bot merged 3 commits intokmesh-net:mainfrom
YaoZengzeng:se

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented Apr 30, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1352

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@YaoZengzeng
prevent deletion of addresses that are already occupied by other objects
aa1fb59 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Apr 30, 2025
@kmesh-bot kmesh-bot requested review from kwb0523 and nlgwcy April 30, 2025 08:29
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (1efb096) to head (82e0dce).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/cache/service_cache.go 82.35% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/controller/workload/cache/workload_cache.go 69.35% <100.00%> (+3.90%) ⬆️
pkg/controller/workload/cache/service_cache.go 79.24% <82.35%> (+54.24%) ⬆️

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d3fdc...82e0dce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu reviewed May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test coverage for it

@YaoZengzeng
add ut
1c18213 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added size/L and removed size/M labels May 6, 2025
@YaoZengzeng
fix lint
82e0dce 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
hzxuzhonghu
hzxuzhonghu approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 5804bdd into kmesh-net:main May 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kwb0523 kwb0523 Awaiting requested review from kwb0523

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/bug Something isn't working lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestServiceEntrySelectsWorkloadEntry flake

3 participants

@YaoZengzeng @kmesh-bot @hzxuzhonghu