Skip to content

fix getKmeshWaypointImage tag#1288

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
silenceper:fix-image-tag
Mar 27, 2025
Merged

fix getKmeshWaypointImage tag#1288
kmesh-bot merged 1 commit intokmesh-net:mainfrom
silenceper:fix-image-tag

Conversation

@silenceper
Copy link
Copy Markdown
Contributor

@silenceper silenceper commented Mar 26, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1287

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kmesh-bot kmesh-bot added the kind/bug Something isn't working label Mar 26, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Mar 26, 2025

Welcome @silenceper! It looks like this is your first PR to kmesh-net/kmesh 🎉

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3a81bcc). Learn more about missing BASE report.
Report is 21 commits behind head on main.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a81bcc...e5ead63. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@silenceper
fix getKmeshWaypointImage tag
e5ead63 
Signed-off-by: silenceper <silenceper@gmail.com>
YaoZengzeng
YaoZengzeng reviewed Mar 27, 2025
View reviewed changes
hzxuzhonghu
hzxuzhonghu approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Mar 27, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 5deb8b4 into kmesh-net:main Mar 27, 2025
12 checks passed
@silenceper silenceper deleted the fix-image-tag branch March 27, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaoZengzeng YaoZengzeng YaoZengzeng left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/bug Something isn't working lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kmeshctl waypoint generate wrong proxyImage tag

4 participants

@silenceper @kmesh-bot @YaoZengzeng @hzxuzhonghu