Skip to content

enable auth offload by default#1274

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
weli-l:dev/auth_ip_optimize
Mar 13, 2025
Merged

enable auth offload by default#1274
kmesh-bot merged 1 commit intokmesh-net:mainfrom
weli-l:dev/auth_ip_optimize

Conversation

@weli-l
Copy link
Copy Markdown
Contributor

@weli-l weli-l commented Mar 13, 2025

What type of PR is this?

What this PR does / why we need it:
Previously, the auth offload function only supported port, so this function was disabled by default. Now auth offload supports ip+port, and the rest of the auth policies can also be transferred to user mode for execution, so this function is enabled by default.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@weli-l
enable auth offload by default
1275356 
Signed-off-by: weli-l <1289113577@qq.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.68%. Comparing base (eeeb399) to head (1275356).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/bpf/bpf.go 42.04% <0.00%> (ø)

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f839eff...1275356. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Mar 13, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit e84e265 into kmesh-net:main Mar 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@LiZhenCheng9527 LiZhenCheng9527 Awaiting requested review from LiZhenCheng9527

@Okabe-Rintarou-0 Okabe-Rintarou-0 Awaiting requested review from Okabe-Rintarou-0

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weli-l @kmesh-bot @hzxuzhonghu