Skip to content

add sample yamls for useguide#1248

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
weli-l:ads/bookinfo
Feb 21, 2025
Merged

add sample yamls for useguide#1248
kmesh-bot merged 2 commits intokmesh-net:mainfrom
weli-l:ads/bookinfo

Conversation

@weli-l
Copy link
Copy Markdown
Contributor

@weli-l weli-l commented Feb 21, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@weli-l
add sample yamls for useguide
f2f292a 
Signed-off-by: weli-l <1289113577@qq.com>
LiZhenCheng9527
LiZhenCheng9527 reviewed Feb 21, 2025
View reviewed changes
samples/tcp-echo/tcp-echo-v1_v2.yaml
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Maybe you can rename this yaml
tcp-echo-v1_v2 -> tcp-echo-v1v2-vs
Or another better name.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.99%. Comparing base (f57bd38) to head (f243598).
Report is 4 commits behind head on main.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57bd38...f243598. Read the comment docs.

@weli-l
modify file name
f243598 
Signed-off-by: weli-l <1289113577@qq.com>
@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented Feb 21, 2025

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Feb 21, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit e368968 into kmesh-net:main Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiZhenCheng9527 LiZhenCheng9527 LiZhenCheng9527 left review comments

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weli-l @LiZhenCheng9527 @kmesh-bot