Conversation
7e43f47 to
097be6f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| void *domain = NULL; | ||
| void *ptr; | ||
| __u32 ptr_length; | ||
| long target_length = bpf_strnlen(addr, BPF_DATA_MAX_LEN); |
There was a problem hiding this comment.
if this is a domain, the length can be longer than BPF_DATA_MAX_LEN
| #define SET_RET_PROTO_TYPE(n, type) (n) = (((n)&0xff00) | ((u32)(type)&0xff)) | ||
| #define GET_RET_PROTO_TYPE(n) ((n)&0xff) | ||
| #define SET_RET_PROTO_TYPE(n, type) (n) = (((n) & 0xff00) | ((u32)(type) & 0xff)) | ||
| #define GET_RET_PROTO_TYPE(n) ((n) & 0xff) |
There was a problem hiding this comment.
Is this an automatic change by clang?
Please reset.
|
/lgtm |
Signed-off-by: weli-l <1289113577@qq.com>
Signed-off-by: weli-l <1289113577@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #553
Special notes for your reviewer:
Does this PR introduce a user-facing change?: