Skip to content

chore: solved contruct_tuple typo #1221#1223

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
yp969803:issue#1221
Feb 8, 2025
Merged

chore: solved contruct_tuple typo #1221#1223
kmesh-bot merged 1 commit intokmesh-net:mainfrom
yp969803:issue#1221

Conversation

@yp969803
Copy link
Copy Markdown
Contributor

@yp969803 yp969803 commented Feb 6, 2025

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
Fix the typo
Which issue(s) this PR fixes:
Fixes #1221

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label Feb 6, 2025
@yp969803
Copy link
Copy Markdown
Contributor Author

yp969803 commented Feb 6, 2025 •
edited
Loading

@hzxuzhonghu @nlgwcy can u review and merge it!

@yp969803
Copy link
Copy Markdown
Contributor Author

yp969803 commented Feb 6, 2025

also can we automate typo checking in CI ?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (de01088) to head (2eb3f92).
Report is 1 commits behind head on main.

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74133b5...2eb3f92. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Feb 7, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Feb 7, 2025

please run git rebase HEAD~1 --signoff and force push again

@yp969803
chore: solved contruct_tuple typo kmesh-net#1221
ae01ffc 
Signed-off-by: Yash Patel <yp969803@gmail.com>
@kmesh-bot kmesh-bot removed the lgtm label Feb 7, 2025
@yp969803
Copy link
Copy Markdown
Contributor Author

yp969803 commented Feb 7, 2025

@hzxuzhonghu done !

hzxuzhonghu
hzxuzhonghu reviewed Feb 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Feb 8, 2025
@kmesh-bot kmesh-bot merged commit 28bd8ad into kmesh-net:main Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved kind/enhancement New feature or request lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in the function name construct_tuple

3 participants

@yp969803 @kmesh-bot @hzxuzhonghu