Merged
Conversation
Contributor
|
When is the plan to support update? |
Contributor
|
/lgtm |
Member
|
can you test it manually since we donot have e2e for this now |
Contributor
Author
|
|
Contributor
LiZhenCheng9527
left a comment
There was a problem hiding this comment.
If your codes has some problem, how do you build successful?
pkg/constants/constants.go
Outdated
| VersionPath = "/bpf_kmesh/map/" | ||
| WorkloadVersionPath = "/bpf_kmesh_workload/map/" | ||
|
|
||
| kmKernelNativeBpfPath = "/bpf_kmesh" |
Contributor
There was a problem hiding this comment.
Suggested change
| kmKernelNativeBpfPath = "/bpf_kmesh" | |
| KmKernelNativeBpfPath = "/bpf_kmesh" |
pkg/constants/constants.go
Outdated
| WorkloadVersionPath = "/bpf_kmesh_workload/map/" | ||
|
|
||
| kmKernelNativeBpfPath = "/bpf_kmesh" | ||
| kmDualEngineBpfPath = "/bpf_kmesh_workload" |
Contributor
There was a problem hiding this comment.
Suggested change
| kmDualEngineBpfPath = "/bpf_kmesh_workload" | |
| KmDualEngineBpfPath = "/bpf_kmesh_workload" |
Signed-off-by: lec-bit <glfhmzmy@126.com>
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
|
In response to a cherrypick label: new pull request created: #1190 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
kmesh currently does not support Update mode. When starting from Update mode, it should start in Normal mode. However, all residual data is not properly cleared, resulting in a startup error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: