Skip to content

Can specify the out name for kmeshctl#1176

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
LiZhenCheng9527:kmeshctl-out
Jan 10, 2025
Merged

Can specify the out name for kmeshctl#1176
kmesh-bot merged 1 commit intokmesh-net:mainfrom
LiZhenCheng9527:kmeshctl-out

Conversation

@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

@LiZhenCheng9527 LiZhenCheng9527 commented Jan 10, 2025

What type of PR is this?

What this PR does / why we need it:

Added out to specify the name after kmeshctl build.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@LiZhenCheng9527
can specify the out name for kmeshctl
e5c49be 
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.23%. Comparing base (186209d) to head (e5c49be).
Report is 170 commits behind head on main.

see 42 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510068d...e5c49be. Read the comment docs.

hzxuzhonghu
hzxuzhonghu approved these changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cherry-pick release-1.0

@kmesh-bot kmesh-bot added the lgtm label Jan 10, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 11d8298 into kmesh-net:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LiZhenCheng9527 @kmesh-bot @hzxuzhonghu