Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| target_ip); | ||
| } | ||
| return match_ipv4_rule(rule_ip, preFixLen, tuple_info, type); | ||
| } else { |
There was a problem hiding this comment.
Doesn't the Ipv6 log need to be added?
There was a problem hiding this comment.
Doesn't the Ipv6 log need to be added?
added
Signed-off-by: weli-l <1289113577@qq.com>
Signed-off-by: weli-l <1289113577@qq.com>
Signed-off-by: weli-l <1289113577@qq.com>
|
/retest |
| AUTH, | ||
| "src ip: %u, dst ip %u, dst port: %u\n", | ||
| ip2str(&tuple_key.ipv6.saddr[0], false), | ||
| ip2str(&tuple_key.ipv6.daddr[0], false), |
There was a problem hiding this comment.
| ip2str(&tuple_key.ipv6.daddr[0], false), | |
| ip2str(&tuple_key.ipv6.daddr, false), |
| DEBUG, | ||
| AUTH, | ||
| "src ip: %u, dst ip %u, dst port: %u\n", | ||
| ip2str(&tuple_key.ipv6.saddr[0], false), |
There was a problem hiding this comment.
| ip2str(&tuple_key.ipv6.saddr[0], false), | |
| ip2str(&tuple_key.ipv6.saddr, false), |
hzxuzhonghu
left a comment
There was a problem hiding this comment.
&IPv6[0] equals &IPv6, correct me if i am wrong
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.0 |
|
@hzxuzhonghu: new pull request created: #1177 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1157
Special notes for your reviewer:
Does this PR introduce a user-facing change?: