Remove unnecessary numeric indexes in format strings#71
Merged
kjd merged 3 commits intokjd:py3-onlyfrom Feb 17, 2020
jdufresne:fmt-index
Merged
Remove unnecessary numeric indexes in format strings#71kjd merged 3 commits intokjd:py3-onlyfrom jdufresne:fmt-index
kjd merged 3 commits intokjd:py3-onlyfrom
jdufresne:fmt-index
Conversation
Unnecessary since Python 2.7. Found using pyupgrade. https://github.com/asottile/pyupgrade
Collaborator
|
This would break Python 2.6 compatibility for no benefit. |
Collaborator
Author
|
According to setup.py, Python 2.6 isn't supported: Lines 16 to 17 in 032fc55 |
Collaborator
|
You're not wrong, but nevertheless I believe it does currently work on Python 2.6 and breaking that for no benefit at all seems unnecessary. |
Contributor
|
@jdufresne @kjd There might be a few more examples of this that could be cleaned up in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary since Python 2.7. Found using pyupgrade.
https://github.com/asottile/pyupgrade