Skip to content

Try 6566#5

Closed
kitsuyui wants to merge 3 commits intomainfrom
tmp
Closed

Try 6566#5
kitsuyui wants to merge 3 commits intomainfrom
tmp

Conversation

@kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Oct 22, 2023

Try celery#6566 on fork repository

@kitsuyui kitsuyui changed the base branch from master to main October 22, 2023 14:41
Pass accept when Gossip getting consumers.
@kitsuyui kitsuyui changed the title testing Try 6566 Oct 22, 2023
@kitsuyui
Copy link
Owner Author

kitsuyui commented Oct 22, 2023

failed tests

  • t/unit/worker/test_consumer.py::test_Gossip::test_call_task FAILED
  • t/unit/worker/test_consumer.py::test_Gossip::test_on_elect FAILED
  • t/unit/worker/test_consumer.py::test_Gossip::test_on_elect_ack_win FAILED
  • t/unit/worker/test_consumer.py::test_Gossip::test_on_elect_ack_lose FAILED
  • t/unit/worker/test_consumer.py::test_Gossip::test_on_elect_ack_win_but_no_action FAILED

Error

content_types =
name_to_type = {'json': 'application/json', 'msgpack': 'application/x-msgpack', 'pickle': 'application/x-python-serialize', 'yaml': 'application/x-yaml'}
content_types =
name_to_type = {'json': 'application/json', 'msgpack': 'application/x-msgpack', 'pickle': 'application/x-python-serialize', 'yaml': 'application/x-yaml'}
return {n if '/' in n else name_to_type[n] for n in content_types}
E TypeError: 'Mock' object is not iterable

My patch changes to use Receiver.accept, so the test refers to the mock object and TypeError occurs.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kitsuyui kitsuyui force-pushed the tmp branch 7 times, most recently from a6b88c3 to 2a16981 Compare October 25, 2023 15:47
If event_serializer, result_serializer, accept_content are set correctly, it works normally.
Otherwise, an error is output to the log. Test that.
@kitsuyui
Copy link
Owner Author

celery#6566 is merged and released

@kitsuyui kitsuyui closed this Dec 18, 2023
@kitsuyui kitsuyui deleted the tmp branch December 18, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants