bin/flatcar-install: randomize OEM filesystem UUID if mounting fails#47
Merged
pothos merged 3 commits intoflatcar-masterfrom Aug 31, 2021
Merged
bin/flatcar-install: randomize OEM filesystem UUID if mounting fails#47pothos merged 3 commits intoflatcar-masterfrom
pothos merged 3 commits intoflatcar-masterfrom
Conversation
Member
Author
|
Have to change this again because the qemu image is qcow2 and writing it to the disk without converting doesn't work of course. |
The QEMU OEM image is qcow2 and can't be written to disk as is. Use the generic image and not the QEMU image when installing from QEMU.
a2b60f8 to
ef5846c
Compare
When an identical BTRFS filesystem is already mounted because the installing system has the same OEM partition version, the mounting of the installed OEM partition fails because identical UUIDs are only allowed to be used for btrfs multi device setups. Randomize the filesystem UUID in case mounting fails and try again.
ef5846c to
6371236
Compare
jepio
approved these changes
Aug 31, 2021
sayanchowdhury
approved these changes
Aug 31, 2021
Member
sayanchowdhury
left a comment
There was a problem hiding this comment.
LGTM, but would be good to have someone else to have a look as well 👁️ 👁️
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 31, 2021
This pulls in flatcar/init#47 to randomize OEM filesystem UUID if mounting fails, and to avoid trying to install the QEMU qcow2 images.
sayanchowdhury
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 31, 2021
This pulls in flatcar/init#47 to randomize OEM filesystem UUID if mounting fails, and to avoid trying to install the QEMU qcow2 images.
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
This pulls in flatcar/init#47 to randomize OEM filesystem UUID if mounting fails, and to avoid trying to install the QEMU qcow2 images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an identical BTRFS filesystem is already mounted because the
installing system has the same OEM partition version, the mounting
of the installed OEM partition fails because identical UUIDs are
only allowed to be used for btrfs multi device setups.
Randomize the filesystem UUID in case mounting fails and try again.
The QEMU OEM image is qcow2 and can't be written to disk as is.
Use the generic image and not the QEMU image when installing from QEMU.
How to use
Testing done
qemuas default OEM value in the-houputsudo ./flatcar-install -d /dev/vdb -i test.ignon the Alpha release generic image, installing the generic image,btrfstuneis invoked: