Conversation
But don't hog all `VM_NCPUS`, as we are still emulating them Signed-off-by: Vincent Batts <vbatts@kinvolk.io>
dongsupark
reviewed
Sep 18, 2020
| arm64-usr+*) | ||
| set -- -machine virt -cpu cortex-a57 -smp 1 -nographic "$@" ;; | ||
| if test "${VM_NCPUS}" -gt 4 ; then | ||
| VM_NCPUS=4 |
Member
There was a problem hiding this comment.
If the actual number of CPUs is equal to 4, then the result VM_NCPUS becomes 2.
Isn't it supposed to be -ge 4?
Member
There was a problem hiding this comment.
I think that's ok to use 2 if there are just 4 available.
| if test "${VM_NCPUS}" -gt 4 ; then | ||
| VM_NCPUS=4 | ||
| elif test "${VM_NCPUS}" -gt 2 ; then | ||
| VM_NCPUS=2 |
Member
There was a problem hiding this comment.
Same.
Isn't it supposed to be -ge 2?
pothos
approved these changes
Dec 15, 2020
Member
Author
|
(thanks for the bump. i had forgotten about this PR 😬 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qemu_template: use more cpus for ARM if available
add some logic to provide more CPUs (than hardcoded '1') for ARM.
But don't hog all
VM_NCPUS, as we are still emulating themSigned-off-by: Vincent Batts vbatts@kinvolk.io
How to use
This script will end up in the release artifacts, so I tested this diff running the most recent arm build (2605.1.0)
Testing done