Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

x11-drivers/nvidia-drivers: Handle NVIDIA Version upgrades#762

Merged
sayanchowdhury merged 1 commit intomainfrom
sayan/handle-nvidia-upgrades
Feb 3, 2021
Merged

x11-drivers/nvidia-drivers: Handle NVIDIA Version upgrades#762
sayanchowdhury merged 1 commit intomainfrom
sayan/handle-nvidia-upgrades

Conversation

@sayanchowdhury
Copy link
Copy Markdown
Contributor

x11-drivers/nvidia-drivers: Handle NVIDIA Version upgrades

Move the NVIDIA variables into a seperate file inorder to handle them
when Flatcar upgrade happens

Signed-off-by: Sayan Chowdhury sayan@kinvolk.io

How to use

emerge-amd64-usr x11-drivers/nvidia-drivers

Testing done

No testing done yet.

doexe "${FILESDIR}/bin/setup-nvidia"
insinto "/usr/share/oem"
doins -r "${FILESDIR}/units"
exeinto "/usr/share/nvidia"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also be insinto and doins, or?

Copy link
Copy Markdown
Contributor

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file needs to be in a separate package that is installed in the generic image

@sayanchowdhury sayanchowdhury force-pushed the sayan/handle-nvidia-upgrades branch from eaa2f2d to dc19207 Compare January 8, 2021 11:16
. /usr/share/nvidia/release

NVIDIA_DRIVER_VERSION=450.80.02
NVIDIA_PRODUCT_TYPE=tesla
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the product type change with the release version? I thought it was associated with the card in the machine and thus it would be hardware dependent, not release dependent, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the product type change with the release version? I thought it was associated with the card in the machine and thus it would be hardware dependent, not release dependent, no?

No, the product type cannot change with the release version. tesla is the name behind the data center GPUs that NVIDIA manufactures. The product type is an umbrella for a couple of hardware in that category. Though I read somewhere NVIDIA is planning to drop the name tesla to avoid confusion.

@sayanchowdhury sayanchowdhury force-pushed the sayan/handle-nvidia-upgrades branch from dc19207 to c2bab6e Compare January 8, 2021 13:23
@sayanchowdhury sayanchowdhury marked this pull request as ready for review January 9, 2021 04:56
@sayanchowdhury sayanchowdhury force-pushed the sayan/handle-nvidia-upgrades branch 2 times, most recently from 30aee11 to 7c764fc Compare January 25, 2021 13:58
Move the NVIDIA variables into a seperate file inorder to handle them
when Flatcar upgrade happens

Signed-off-by: Sayan Chowdhury <sayan@kinvolk.io>
@sayanchowdhury sayanchowdhury force-pushed the sayan/handle-nvidia-upgrades branch from 7c764fc to ada06ee Compare February 2, 2021 05:39
Copy link
Copy Markdown
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sayanchowdhury sayanchowdhury merged commit 7dcb725 into main Feb 3, 2021
@sayanchowdhury sayanchowdhury deleted the sayan/handle-nvidia-upgrades branch February 3, 2021 09:10
sayanchowdhury added a commit that referenced this pull request Feb 12, 2021
x11-drivers/nvidia-drivers: Handle NVIDIA Version upgrades
sayanchowdhury added a commit that referenced this pull request Jul 21, 2021
x11-drivers/nvidia-drivers: Handle NVIDIA Version upgrades
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants