Skip to content

fix: removes duplicate base from resolved src#145

Closed
ndj91 wants to merge 1 commit intokindspells:mainfrom
ndj91:main
Closed

fix: removes duplicate base from resolved src#145
ndj91 wants to merge 1 commit intokindspells:mainfrom
ndj91:main

Conversation

@ndj91
Copy link
Copy Markdown

@ndj91 ndj91 commented Oct 11, 2024

Fixes issue #144

@dnlek
Copy link
Copy Markdown

dnlek commented Oct 15, 2024

💯

@ndj91
Copy link
Copy Markdown
Author

ndj91 commented Oct 17, 2024

Hi @castarco,

How are you?
Just wondering if you've had a chance to look at this one?

@castarco
Copy link
Copy Markdown
Contributor

castarco commented Nov 2, 2024

Hi everyone, @ndj91 . I'm sorry I wasn't available for so long, it has been a long time of crushing load work for me. I'll be reviewing issues and PRs this weekend.

@castarco
Copy link
Copy Markdown
Contributor

castarco commented Nov 2, 2024

@ndj91 so far looks good, but the formatting is all off. Please run

  • pnpm format
  • git commit --amend
  • git rebase -i main
  • git push origin --force-with-lease

Thank you for your effort 🙏🏻 .

@castarco
Copy link
Copy Markdown
Contributor

castarco commented Nov 2, 2024

@ndj91 I created a parallel PR (#158) including your commit with the change requests I mentioned here, your authorship is preserved, but the commit will appear as dual because of the formatting changes I included.

I'll be releasing your changes in a few minutes :) .

@castarco castarco closed this Nov 2, 2024
@ndj91
Copy link
Copy Markdown
Author

ndj91 commented Nov 20, 2024

Thanks for that, was also super busy with work and didn't see.

Appreciate you jumping on and getting this merge in asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants