Skip to content

Change property drawers and gitignore#44

Merged
kimsama merged 10 commits intokimsama:masterfrom
JohannesDeml:master
Dec 8, 2017
Merged

Change property drawers and gitignore#44
kimsama merged 10 commits intokimsama:masterfrom
JohannesDeml:master

Conversation

@JohannesDeml
Copy link
Copy Markdown
Contributor

Especially chaning the serialized propertie names from anme to display name makes everything more readable. The style also didn't look that good with the light skin.

Here is how it looks now:

grafik

@kimsama
Copy link
Copy Markdown
Owner

kimsama commented Oct 23, 2017

Hi, JohannesDeml

Great! Thank you for that all proceedings. I'll merge after review.

Thank you again.

@JohannesDeml
Copy link
Copy Markdown
Contributor Author

JohannesDeml commented Oct 23, 2017

Sure, no thing. I might have been a bit harsh with the enum drawer and the background (by just removing those).
As for the background: It didn't look good with the light skin.
As for the enum: I think it has to many fields. I didn't quite understand why you would want to expose so many.

Looking forward to your feedback :)

Btw. I really like the project and hopefully I will have time to implement a few more of my ideas how to make the tool more accessible and useful!

@kimsama kimsama merged commit 2289866 into kimsama:master Dec 8, 2017
@kimsama
Copy link
Copy Markdown
Owner

kimsama commented Dec 9, 2017

I moved all example related files under Assets/QuickSheet/Example folder to make it easy to keep maintenance.

@JohannesDeml
Copy link
Copy Markdown
Contributor Author

Nice, that sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants