Merged
Conversation
Deploying asbplayer with
|
| Latest commit: |
9549056
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89fdf063.asbplayer.pages.dev |
| Branch Preview URL: | https://yomitan-mecab.asbplayer.pages.dev |
c8a45db to
3150540
Compare
Collaborator
Author
|
I added more checks and instructions in case a user has an outdated installer or a dictionary that doesn't support the lemma from Prefer newer |
37aaa65 to
0ec4fa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #933
Added a new Yomitan option to choose between the
scanning-parserandmecabfrom a dropdown. When mecab is selected we will verify if the user has it correctly installed by sending a test tokenize string and inspecting the response. This is now possible is mecab is Japanese only.We should wait for yomidevs/yomitan-mecab-installer#12 to be merged otherwise users may have to install twice.