Allow collecting tokens with no dictionary entry#929
Merged
killergerbah merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
fd01470 to
9103dcf
Compare
Deploying asbplayer with
|
| Latest commit: |
fb2e7ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7776cebf.asbplayer.pages.dev |
| Branch Preview URL: | https://collect-ungrouped-segments.asbplayer.pages.dev |
9103dcf to
04955da
Compare
04955da to
fb2e7ed
Compare
killergerbah
reviewed
Mar 8, 2026
killergerbah
approved these changes
Mar 8, 2026
Owner
|
I just tested this with the Japanese YT video mentioned in the original issue and the ー character in ずーっと is not being rendered on this version of the code 
|
Owner
|
Ah never mind I'm idiot |
|
Yeah that was a miscommunication on my part I made those subtitles using whisper.cpp lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #927
The Yomitan parser simply tries to find the longest dictionary entry possible left to right in order to tokenize. It's possible for some tokens to be non-dictionary entries (until the next dictionary entry-able set of characters appear) which of course won't have any lemmas when we look for them. These entries should just be created with their own token as a lemma to allow the user to collect them.
I modified the strategy logic to fall back to exact if the lemma is missing. We cannot just always add the token as the lemma as we want the failure in all other use cases of
lemmatize().