Skip to content

feat(subtitles): support token reading annotations#835

Merged
killergerbah merged 1 commit intokillergerbah:mainfrom
ShanaryS:reading-annotations
Dec 3, 2025
Merged

feat(subtitles): support token reading annotations#835
killergerbah merged 1 commit intokillergerbah:mainfrom
ShanaryS:reading-annotations

Conversation

@ShanaryS
Copy link
Copy Markdown
Collaborator

@ShanaryS ShanaryS commented Dec 1, 2025

  • Use Yomitan to add ruby annotations to the tokens (e.g. furigana).
    • Options are: Always, Learning or below, Unknown or below, Never
    • Tied to colorization being enabled for now, will be easier to enable individually once we move to IndexedDB
  • Option to display richText only on hover similar to unblur to avoid "cheating"
    • Applies to both coloring and annotations, not much value in separating if the goal is avoiding "cheating"
    • Applies to the entire subtitle event not per token as I feel it's actually a better experience
    • Works by rendering both html but setting richText to display: none until hovered where they are swapped.

@ShanaryS ShanaryS self-assigned this Dec 1, 2025
@ShanaryS ShanaryS added the enhancement New feature or request label Dec 1, 2025
@ShanaryS ShanaryS requested a review from killergerbah December 1, 2025 19:26
@ShanaryS ShanaryS force-pushed the reading-annotations branch from ab89367 to 8b46ba0 Compare December 1, 2025 20:22
Copy link
Copy Markdown
Owner

@killergerbah killergerbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks
We may want to move the settings around / change some wording a bit later

@killergerbah killergerbah merged commit 3cfd154 into killergerbah:main Dec 3, 2025
1 check passed
@ShanaryS ShanaryS deleted the reading-annotations branch December 3, 2025 00:27
@killergerbah killergerbah added this to the Extension v1.14.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants