Add support for cijapanese.com#804
Merged
killergerbah merged 8 commits intokillergerbah:mainfrom Oct 24, 2025
Merged
Conversation
Owner
|
@Bennycopter Thanks for doing this! The subtitle detection seems to be working. Can you make this change? And then fix any remaining compile errors from running And finally, add the favicon for cijapanese.com to |
Address pr comments for cijapanese.com
Contributor
Author
|
Thank you @killergerbah! :) My PR now includes everything you asked for:
When you update the contributors, please also add @extremq as he did a PR to my PR to help get this through quicker, lol. Best regards |
Owner
|
Awesome, thank you @Bennycopter ! |
killergerbah
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds preliminary support for using the asbplayer extension on Comprehensible Japanese.
Motivation
Several users on our site (Comprehensible Japanese) have requested asbplayer compatibility, so I'm submitting this pull request.
Changes
extension/src/entrypoints/cijapanese-page.tsextension/src/pages.jsonextension/wxt.config.tsNotes
I'm not fully familiar with using the asbplayer extension, so I'm not sure if this covers everything that's needed for it to function normally. Please let me know if there's anything missing that I can help with. 🙏