Update Missing Key from Indonesian Translation#769
Merged
killergerbah merged 2 commits intokillergerbah:mainfrom Sep 16, 2025
Merged
Update Missing Key from Indonesian Translation#769killergerbah merged 2 commits intokillergerbah:mainfrom
killergerbah merged 2 commits intokillergerbah:mainfrom
Conversation
Contributor
Author
|
FYI: GitHub Actions build failed on my fork at yarn workspace @project/extension run zip. This looks unrelated to the translation update, might be environment/workflow related(?) 
|
killergerbah
requested changes
Sep 7, 2025
Owner
killergerbah
left a comment
There was a problem hiding this comment.
Thanks for the amazing work
Just a couple things to fix and the verify job should pass
common/locales/id.json
Outdated
| "adjustOffset": "Sesuaikan offset takarir ±100 ms", | ||
| "adjustOffsetToNextSubtitle": "Sesuaikan offset takarir agar takarir berikutnya berada di waktu saat ini", | ||
| "increaseSubtitlePositionOffset": "Tambah Offset Posisi Takarir", | ||
| "increaseTopSubtitlePositionOffset": "Tambah Offset Posisi Takarir Atas" |
Owner
There was a problem hiding this comment.
Missing comma at end of line
common/locales/id.json
Outdated
| "binds": { | ||
| "adjustOffset": "Sesuaikan offset takarir ±100 ms", | ||
| "adjustOffsetToNextSubtitle": "Sesuaikan offset takarir agar takarir berikutnya berada di waktu saat ini", | ||
| "increaseSubtitlePositionOffset": "Tambah Offset Posisi Takarir", |
Owner
There was a problem hiding this comment.
Some key names changed. You'll need to remove the old ones and add the new ones:
increaseSubtitlePositionOffset->moveBottomSubtitlesUpdecreaseSubtitlePositionOffset->moveBottomSubtitlesDownincreaseTopSubtitlePositionOffset->moveTopSubtitlesUpdecreaseTopSubtitlePositionOffset->moveTopSubtitlesDown
yaaacha
commented
Sep 7, 2025
Owner
|
@yaaacha Thanks again! |
Contributor
Author
|
my pleasure😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.