Add subtitle position offset keyboard shortcuts#759
Merged
killergerbah merged 10 commits intokillergerbah:mainfrom Aug 20, 2025
Merged
Add subtitle position offset keyboard shortcuts#759killergerbah merged 10 commits intokillergerbah:mainfrom
killergerbah merged 10 commits intokillergerbah:mainfrom
Conversation
killergerbah
requested changes
Aug 9, 2025
Owner
killergerbah
left a comment
There was a problem hiding this comment.
Thanks for spending the time to do this!
killergerbah
requested changes
Aug 20, 2025
Owner
killergerbah
left a comment
There was a problem hiding this comment.
Thanks for your patience - was away for from my computer for a bit. Just one last nitpick.
Owner
|
Amazing stuff, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for #751
Pretty standard keyboard shortcut implementation. The only thing that was kind of tricky was updating the settings (to sync w/ the popup window) for the extension in key-bindings.ts. I'm not too familiar with the codebase so hopefully I didn't miss anything 🤞.