Skip to content

Improved Naming scheme for video in Emby/Jellyfin#729

Merged
killergerbah merged 3 commits intokillergerbah:mainfrom
bpwhelan:main
Jun 14, 2025
Merged

Improved Naming scheme for video in Emby/Jellyfin#729
killergerbah merged 3 commits intokillergerbah:mainfrom
bpwhelan:main

Conversation

@bpwhelan
Copy link
Copy Markdown
Contributor

@bpwhelan bpwhelan commented Jun 6, 2025

Unify and improve the the naming scheme for the "Video Name" in both Emby and Jellyfin. This will result in more consistent naming between the two and provide a lot more useful information for jellyfin folk.

Before and After JF:
chrome_Otxp2BrRrs

Before and After Emby:
chrome_X5RX2HU1Xm

@bpwhelan
Copy link
Copy Markdown
Contributor Author

bpwhelan commented Jun 6, 2025

I could see potentially removing the item id for cleanliness, but it could be potentially useful information for scripting, like if you wanted to find that episode in the future programmatically you can parse that and construct a url to take you straight there.

@killergerbah
Copy link
Copy Markdown
Owner

killergerbah commented Jun 8, 2025

@bpwhelan Can you add reasonable fallback behavior in case some of the NowPlayingItem fields are not defined? It looks like FileName is the only field guaranteed to be defined.

image

@bpwhelan
Copy link
Copy Markdown
Contributor Author

bpwhelan commented Jun 8, 2025

@killergerbah I think FileName is not available for Jellyfin IIRC, but I believe Path is valid for both (当たり前でしょ), I will look at getting the filename from that field to bring it more in line with the asbplayer app naming scheme and scrap the NowPlayingItem fields

@bpwhelan
Copy link
Copy Markdown
Contributor Author

bpwhelan commented Jun 8, 2025

Changed to use Path, and fall back to previous behavior if Path doesn't exist (should never happen, just safety)

Emby behavior unchanged from main branch.

Emby

image

JF

image

@killergerbah
Copy link
Copy Markdown
Owner

@bpwhelan Thanks! This looks good. Final suggestion is to use your original naming format if it's possible. P2 would be to use the parts that are available in NowPlayingItem if only some parts are missing.

@killergerbah
Copy link
Copy Markdown
Owner

Merging this but feel free to implement your original naming scheme if you'd like. Thanks for the contribution!

@killergerbah killergerbah merged commit e0235be into killergerbah:main Jun 14, 2025
1 check passed
@bpwhelan
Copy link
Copy Markdown
Contributor Author

Sorry meant to reply, if I were to do anything it would have to be all or nothing (either all of the nowplayingitem fields or just use filename)

But I think filename makes the most sense as it's consistent with how the app works.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants