Paint subtitle stroke behind text fill#723
Merged
killergerbah merged 1 commit intokillergerbah:mainfrom May 31, 2025
Merged
Conversation
Contributor
Author
|
It should also prevent the issue with overlapping lines mentioned by the comment by the way. |
Owner
|
Great improvement! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently subtitle outlines cause the text itself to be overdrawn. This limits the outline thickness one can select before the text becomes unreadable. It is possible to increase the font thickness to remedy this issue a bit, but the result can look odd and requires weird balancing between the two options.
This PR forces the outline to be drawn behind the text itself, making all text outline and text thickness combinations work well without any issues.
The
paint-ordercss property went baseline last year so using it should be fine.