Add setting to control how HTML in subtitles is handled#686
Add setting to control how HTML in subtitles is handled#686killergerbah merged 1 commit intokillergerbah:mainfrom
Conversation
HTML tags can either be removed or rendered, in all places where you see subtitles
|
@kowasaur Thank you for spending the time to do this. There is just one thing I want to check, which is that it's fine to filter out the HTML for any file format. I don't remember exactly why, but my guess is that I was filtering depending on file extensions since it only makes sense for HTML to appear for particular subtitle formats and not for others. However I can see the argument for why this might not matter and we should just filter or not-filter for any format. |
|
OK I looked into this briefly and almost all the subtitle formats supported by asbplayer have at least partial support for HTML except for ASS and BluRay which is image-based. But it's very unlikely that anyone will care if XML starts disappearing from their ASS subtitles. So will just go ahead and merge this change given the value it provides. Thank you! |
|
Thanks for taking the time to look into this! |
Currently, whether HTML tags are removed from subtitles depends on the file type. Also, for subtitles where HTML tags are not removed, the HTML is not rendered properly in many places.
This pull request:
This is what the setting looks like
The following examples use this SRT file
This is the video player with "remove" selected
This is the video player with "render" selected
Sorry that I didn't add anything to
loc/untranslated/*.json. I tried runningscripts/loc/seed-untranslated.jsbut it added a lot more than the things I added so I thought that's probably not what I'm supposed to do.