Websocket - Sync timestamp command#664
Merged
killergerbah merged 4 commits intokillergerbah:mainfrom Mar 7, 2025
Merged
Conversation
killergerbah
requested changes
Mar 3, 2025
Owner
|
Just run prettier on your changes and should be good to merge |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new WebSocket command to sync to a specific timestamp in the video. I’ve tested it locally in Chrome and followed the
load-subtitlesimplementation to keep it consistent with existing code.I’m building a vocabulary mining program that scans subtitles to find words and phrases you haven’t mined yet. This feature makes it convenient—users can click a timestamp in the program and jump straight to that spot in the video to mine it with asbplayer. I’m sure other projects could find this useful too.