Skip to content

Fix Jellyfin Subtitles#661

Merged
killergerbah merged 1 commit intokillergerbah:mainfrom
MarvNC:fix-jellyfin-subs
Mar 3, 2025
Merged

Fix Jellyfin Subtitles#661
killergerbah merged 1 commit intokillergerbah:mainfrom
MarvNC:fix-jellyfin-subs

Conversation

@MarvNC
Copy link
Copy Markdown
Contributor

@MarvNC MarvNC commented Feb 24, 2025

For some subtitle types like .mov_text Jellyfin will return an error bad request. Luckily we can just request .srt and Jellyfin will produce one, even if the subtitle wasn't originally .srt. Not sure if it works with all types of subs though, might need some testing.

@killergerbah
Copy link
Copy Markdown
Owner

It seems like asking Jellyfin to convert to srt has more predictable behavior than just passing the original "codec" through. I don't have time to test this thoroughly myself, but theory this should always work according to this: https://github.com/jellyfin/jellyfin/blob/efb901c36976c006f2b9ad8420a06181819c9016/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs#L154

Thanks!

@killergerbah killergerbah merged commit b960002 into killergerbah:main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants