-
Notifications
You must be signed in to change notification settings - Fork 173
Comparing changes
Open a pull request
base repository: asbplayer/asbplayer
base: v1.12.0
head repository: asbplayer/asbplayer
compare: v1.13.0
- 20 commits
- 53 files changed
- 8 contributors
Commits on Sep 27, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 7e1c6ba - Browse repository at this point
Copy the full SHA 7e1c6baView commit details
Commits on Oct 4, 2025
-
Update Indonesian Translation for Version 1.12 (#792)
* Update id.json * Update id.json * Update Indonesian Translation for Version 1.12 Update untranslated part, fix mistranslation, and minor change
Configuration menu - View commit details
-
Copy full SHA for dd57ba6 - Browse repository at this point
Copy the full SHA dd57ba6View commit details
Commits on Oct 12, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e6bc2d3 - Browse repository at this point
Copy the full SHA e6bc2d3View commit details -
Add .webm support to file input extensions (#802)
* Add .webm support to file input extensions * Fix formatting --------- Co-authored-by: R-J Lim <kgerbil@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cde4899 - Browse repository at this point
Copy the full SHA cde4899View commit details
Commits on Oct 13, 2025
-
Configuration menu - View commit details
-
Copy full SHA for ed57f6b - Browse repository at this point
Copy the full SHA ed57f6bView commit details
Commits on Oct 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 9e6b14d - Browse repository at this point
Copy the full SHA 9e6b14dView commit details -
Revert "Move mp3 encoding into background script to avoid CSP restric…
…tions" This reverts commit 9e6b14d.
Configuration menu - View commit details
-
Copy full SHA for af33530 - Browse repository at this point
Copy the full SHA af33530View commit details
Commits on Oct 17, 2025
-
Revert "Revert "Move mp3 encoding into background script to avoid CSP…
… restrictions"" This reverts commit af33530.
Configuration menu - View commit details
-
Copy full SHA for 9bbe552 - Browse repository at this point
Copy the full SHA 9bbe552View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41df16b - Browse repository at this point
Copy the full SHA 41df16bView commit details
Commits on Oct 24, 2025
-
* New UI Add a button to the side panel overlay for bulk export and an overlay for the export in progress * Services and handlers Adding extra state for cancellation is kind of a PITA but cancellation just waits for the export to finish without it. This is mixing exceptions and empty strings--I'm coming from a C++ background and exceptions kind of scare me, so I tried to avoid them unless it looked like a big diff to avoid them the NoRecordingInProgressErrors had a precedent so I got a bit lazy. * Piping and logic for card creation and export Like the last change, this involves some error softening as we plow through an export * The whole export loop in SidePanel.tsx * First pass at moving logic to the controller This still tests alright * Remove the rest of the changes from mining-context * Push exportMode from CardModel to Message This state was already in a few other messages, so we just had to add it to CardExportedMessage(). * Replace empty string error handling with exceptions Adds DuplicateNoteError for when a card already exists Adds AudioRequestSupersededError for when the recorder gets preempted * Not from code review: cut down on the `as any` * Not from code review: notify user on duplicate card Before this, we'd just display "card exported: x/y" as before I'm also removing the initial notify progress, which would display "card exported: x/y" before we even started exporting. * Not from code review: disable bulk export while a normal export is happening This puts the app in a weird state so this just greys out the control in the overlay while a card is recording * Remove AnkiExportMode.bulk enum and refactor to use separate methods Replace the 'bulk' export mode with a boolean flag and separate publish methods to simplify the branching logic in CardPublisher. Addresses: "Sorry for realizing this so late, but it doesn't seem like a distinct..." "Is there a reason you're writing this instead of..." "I would recommend writing a new public method specifically for bulk export..." "exportMode appears to be unused..." "As mentioned in my comment on model.ts..." "As mentioned elsewhere, I think you should branch here..." * Just make bulkExportCancelled a public bool Addresses "Nitpick: it's probably more efficient..." * Fire-and-forget in bulk export controller Addresses "I think in this case fire-and-forget is fine..." * Also notify progress on generic errors Addresses "Also: if CardExportedMessage.exportError is..." * Remove AudioRequestSupersededError Responds to: "In this case, would we be exporting a card..." "Was this change necessary? From what I can tell, re-record..." * Remove dead forced UI update * Move duplicate error throw into general code; remove extra string check Addresses "This if -> throw block can be moved into _executeAction" and my response to it * Run yarn pretty * Remove erroring line * Stop dropping exceptions on the floor and remove duplicate sendMessage * Use BulkExportStartedPayload * Revert control flow changes in drm error catch * Return with index in currentSubtitle Code review aside, we also get to remove some logic in the BulkExportController * Fix build errors --------- Co-authored-by: R-J Lim <kgerbil@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6a0ea6c - Browse repository at this point
Copy the full SHA 6a0ea6cView commit details -
Add support for cijapanese.com (#804)
* Added support for cijapanese.com * Address pr comments for cijapanese.com * minor fixes * Run prettier --------- Co-authored-by: extremq <45830561+extremq@users.noreply.github.com> Co-authored-by: R-J Lim <kgerbil@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 035a70d - Browse repository at this point
Copy the full SHA 035a70dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ccbf2 - Browse repository at this point
Copy the full SHA c3ccbf2View commit details
Commits on Oct 25, 2025
-
Configuration menu - View commit details
-
Copy full SHA for dfd05ef - Browse repository at this point
Copy the full SHA dfd05efView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed5150b - Browse repository at this point
Copy the full SHA ed5150bView commit details
Commits on Oct 28, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e20e57c - Browse repository at this point
Copy the full SHA e20e57cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9295e6b - Browse repository at this point
Copy the full SHA 9295e6bView commit details
Commits on Nov 1, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 525ce8f - Browse repository at this point
Copy the full SHA 525ce8fView commit details
Commits on Nov 4, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 9407187 - Browse repository at this point
Copy the full SHA 9407187View commit details
Commits on Nov 6, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2202567 - Browse repository at this point
Copy the full SHA 2202567View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09dd714 - Browse repository at this point
Copy the full SHA 09dd714View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.12.0...v1.13.0