Skip to content

Preliminary support for sparse indices#870

Closed
MoSal wants to merge 7 commits intokillercup:masterfrom
MoSal:update_crates_index_and_support_sparse_indices
Closed

Preliminary support for sparse indices#870
MoSal wants to merge 7 commits intokillercup:masterfrom
MoSal:update_crates_index_and_support_sparse_indices

Conversation

@MoSal
Copy link
Copy Markdown

@MoSal MoSal commented Aug 22, 2023 •
edited
Loading

This will forever be a draft, unless someone adopts it of course. But I hope it will help moving things forward.

This implements preliminary support for sparse indices.

  • All deps are updated/upgraded to latest versions.
  • Git index support removed. Only sparse indices work.
  • Tests are broken since they assume git indices.
  • Crate info is not fetched in parallel for the sake of simplicity. Fetching is still very fast despite that (< 4s for cargo-edit, almost instantaneous with --offline).

ureq was already a dependency for some reason. So I used it after enabling the "gzip" feature.

Note to implementers regarding gix-based GitIndex from the latest crates_index:

  • Some tests fail with hash mismatches.
  • A test fails because the order of output is different (I think).
  • Not sure how locking works with gix.

I didn't inspect those issues further, as I just wanted to make sparse indices work for me.

Related issues: #841, #865, #868, possibly #869

MoSal added 4 commits August 20, 2023 13:53
@MoSal
cargo update
08691ab 
 All tests pass.

Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal
Update indexmap to v2
a35340d 
 All tests pass.

Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal
Update to cargo_metadata v0.17 and fix compatibility
f695be8 
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal
cargo update again to get serde v1.0.185
6b14fec 
 All tests pass.

Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal MoSal marked this pull request as draft August 22, 2023 19:16
@amsam0
Copy link
Copy Markdown

amsam0 commented Aug 23, 2023 •
edited
Loading

git index support should probably be supported by reading the cargo config value, but it seems like a pain to find the config path so I can understand why you wouldn't want to add it, lol

@MoSal MoSal force-pushed the update_crates_index_and_support_sparse_indices branch from a382062 to c016ebf Compare August 23, 2023 09:55
MoSal added 3 commits August 23, 2023 14:39
@MoSal
Upgrade to crates_index v2.1.1 and support sparse indices
89dc239 
 * Git index support removed. Only sparse indices work.
 * Tests are broken since they assume git indices.
 * Crate info is not fetched in parallel for the sake of simplicity.
   Fetching is still very fast despite that.

Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal
cargo update
964c0d0 
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal
cargo upgrade
f0da565 
Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
@MoSal MoSal force-pushed the update_crates_index_and_support_sparse_indices branch from c016ebf to f0da565 Compare August 23, 2023 11:39
@epage
Copy link
Copy Markdown
Collaborator

epage commented Aug 23, 2023

Something to keep in mind is that the FCP is about to close on merging parts of cargo-upgrade into cargo-update after which I'll get to work on doing that and it will be available in a nightly.

@MoSal
Copy link
Copy Markdown
Author

MoSal commented Aug 23, 2023

@epage

Sounds good.

@tgross35
Copy link
Copy Markdown

tgross35 commented Nov 14, 2023 •
edited
Loading

@epage do you have a link to the proposal you mentioned? Wondering what the exact change is but can't find anything.

@epage
Copy link
Copy Markdown
Collaborator

epage commented Nov 14, 2023

rust-lang/cargo#12425

I have a got a lot of the peripheral aspects done but haven't gotten to the core of it yet

@dvc94ch
Copy link
Copy Markdown

dvc94ch commented Mar 18, 2024

does this mean that cargo upgrade is broken for everyone that installed cargo/rust after the new registry format was added? how can I use the old registry format?

@dvc94ch
Copy link
Copy Markdown

dvc94ch commented Mar 18, 2024

what's the alternative right now? installing vscode and the rustrover plugin to update incompatible dependencies?

@epage epage mentioned this pull request Sep 16, 2024
Merged
@epage epage closed this in #907 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MoSal @amsam0 @epage @tgross35 @dvc94ch