Merged
Conversation
If the user doesn't specify anything beyond a positional name or path, we'll check if its a workspace member and add it according to workspace best practices - Use `version` and `path` for published dependencies so it uses the local version for dev and the upcoming version on publish - Use `path` for unpublished dependencies for development without creating version bumping cycles. Fixes killercup#480
ordian
approved these changes
Sep 21, 2021
Collaborator
ordian
left a comment
There was a problem hiding this comment.
Nice! Just one question.
| cargo-list-test-fixture-dependency = { version = "0.0.0", path = "../dependency" } | ||
|
|
||
| [dev-dependencies] | ||
| cargo-list-test-fixture-dependency = { path = "../dependency" } |
Collaborator
There was a problem hiding this comment.
this wasn't introduced in the PR, but shouldn't we skip adding to dev-deps if it's present in deps? I guess same applies to build-deps.
Collaborator
Author
There was a problem hiding this comment.
dev-dependencies can introduce features, make optional dependencies, required, etc. We'd need to interrogate these different settings to make sure we weren't skipping something that needed to happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user doesn't specify anything beyond a positional name or path,
we'll check if its a workspace member and add it according to workspace
best practices
versionandpathfor published dependencies so it uses thelocal version for dev and the upcoming version on publish
pathfor unpublished dependencies for development withoutcreating version bumping cycles.
Fixes #480