Build fix – Fixed flaky tests #2145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vnandwana
commented
Jul 15, 2025
- Rebased to latest master.
- Replaced references to ConfigurationObjectFactory with AugmentedConfigurationObjectFactory where applicable.
This reverts commit 70bafbd.
…ild test loads correct catalog instead of parent’s default. * Restored original system property in afterClass to avoid affecting other tests.
…red repo (this has -U flag).
…o null -- now its set to a mock object instead of null.
This reverts commit 70bafbd.
* Updated ci.yml, overridden ff-goal value.
sbrossie
reviewed
Jul 17, 2025
|
|
||
| @Override | ||
| @BeforeClass(groups = "fast") | ||
| public void beforeClass() throws Exception { |
Member
There was a problem hiding this comment.
Just for my understanding: Any rationale for why this is needed now? If we don't have this, do the tests fail and how its this related to the config work?
|
|
||
| @Override | ||
| @BeforeClass(groups = "fast") | ||
| public void beforeClass() throws Exception { |
Member
There was a problem hiding this comment.
If this is needed in all tests, should this be part of SubscriptionTestSuiteNoDB ?
| </JavaCodeStyleSettings> | ||
| <XML> | ||
| <option name="XML_ATTRIBUTE_WRAP" value="0" /> | ||
| <option name="XML_LEGACY_SETTINGS_IMPORTED" value="true" /> |
.idea/misc.xml
Outdated
| <option value="$PROJECT_DIR$/pom.xml" /> | ||
| </list> | ||
| </option> | ||
| <option name="workspaceImportForciblyTurnedOn" value="true" /> |
.github/workflows/ci.yml
Outdated
| uses: killbill/gh-actions-shared/.github/workflows/ci.yml@main | ||
| uses: killbill/gh-actions-shared/.github/workflows/ci.yml@main | ||
| with: | ||
| ff-goal: '-Dsurefire.parallel=none -U clean test verify' |
Member
There was a problem hiding this comment.
Does it mean tests used to run in parallel, and not anymore? Any reason for this - and if so how will this impact performance of our CI build?
Contributor
Author
There was a problem hiding this comment.
Thank you for the review comments. These changes were unintentional and were made while trying to fix flaky tests (mostly during local testing). I removed code that's no longer needed.
sbrossie
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.