Fix for aviate plugin 336 #2083
Conversation
| getBundleId(), | ||
| getBundleExternalKey(), | ||
| List.of(new DefaultEntitlementSpecifier(null, null, null, getExternalKey(), null)), | ||
| List.of(new DefaultEntitlementSpecifier(spec.getPlanPhaseSpecifier(), spec.getBillCycleDay(), spec.getQuantity(), getExternalKey(), spec.getOverrides())), |
There was a problem hiding this comment.
Am i understanding correctly that we were not passing correctly the details of the EntitlementSpecifier to the entitlement plugins for change operations - in this case should we also fix the other methods changePlanWithDate, ... ?
There was a problem hiding this comment.
Am i understanding correctly that we were not passing correctly the details of the EntitlementSpecifier to the entitlement plugins for change operations
Yes that is correct. Yes, I think we need to fix the other changePlanWithXXX methods. I'm also wondering if we should make this change in the cancelPlanWithXXX methods? For example here?
There was a problem hiding this comment.
We should pass all the info to the plugin through the EntitlementContext pluginContext. In the case of cancelation, there is no spec though, so not clear that we are missing anything. If you see anything missing, please add it. Definitely needed for other changePlanWithXXX.
There was a problem hiding this comment.
Taking a look again, you are right, there is no need to make changes to the cancelXXX methods. I've made changes to all the changePlanWithXXX methods in 92bc89c.
Fix for https://github.com/killbill/killbill-aviate-plugin/issues/336